p2p: Implement P2P Bucket data structure #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-p2p
SyntheticBird45
changed the title
SyntheticBird45
force-pushed
the
p2p_bucket
branch
from
63abd36
to
73ad301
Compare
Boog900
requested changes
Oct 30, 2024
hinto-janai
reviewed
Oct 30, 2024
There was a problem hiding this comment.
Can you add this crate to here?: https://github.com/Cuprate/cuprate/blob/main/books/architecture/src/appendix/crates.md
SyntheticBird45
force-pushed
the
p2p_bucket
branch
from
73ad301
to
8a58145
Compare
github-actions
bot
added
A-docs
Boog900
reviewed
Nov 1, 2024
Boog900
reviewed
Nov 2, 2024
This commit implements a "Bucket" data structure that is a collection of data that discriminates its items into "buckets" (vector of size N) following a defined function. - Implements Bucket data structure and Bucketable trait - Implements Bucketable for Ipv4Addr - Added the crate to the workspace dependencies - Added arrayvec as a dependency
SyntheticBird45
force-pushed
the
p2p_bucket
branch
from
eea7001
to
c104d65
Compare
Boog900
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See: #178
This PR implements a "Bucket" data structure that is a collection of data that discriminates its items into "buckets" (vector of size N) following a defined function.
arrayvecas a dependencyWhy
The end goal is to use this structure to store diverse IPs of different /16 subnets.